Skip to content

Conversation

@JereSalo
Copy link
Contributor

@JereSalo JereSalo commented Nov 11, 2025

Motivation

Description

  • When running L1 and L2 in dev mode these directories are created and we weren't ignoring them.

@JereSalo JereSalo self-assigned this Nov 11, 2025
@github-actions github-actions bot added L1 Ethereum client L2 Rollup client labels Nov 11, 2025
@JereSalo JereSalo marked this pull request as ready for review November 28, 2025 17:19
@JereSalo JereSalo requested a review from a team as a code owner November 28, 2025 17:19
Copilot AI review requested due to automatic review settings November 28, 2025 17:19
@ethrex-project-sync ethrex-project-sync bot moved this to In Review in ethrex_l1 Nov 28, 2025
Copilot finished reviewing on behalf of JereSalo November 28, 2025 17:20
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds ignore patterns for L1 and L2 development mode database directories to prevent them from being tracked in version control and included in Docker builds.

  • Added dev_ethrex_l1/ and dev_ethrex_l2/ to .gitignore
  • Added the same directories to .dockerignore

Reviewed changes

Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.

File Description
.gitignore Adds ignore patterns for dev mode L1 and L2 database directories
.dockerignore Adds the same directory patterns to prevent inclusion in Docker builds

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@JereSalo JereSalo added this pull request to the merge queue Nov 29, 2025
Merged via the queue into main with commit ed949d9 Nov 29, 2025
54 checks passed
@JereSalo JereSalo deleted the ignore_db_directories branch November 29, 2025 21:40
@github-project-automation github-project-automation bot moved this from In Review to Done in ethrex_l1 Nov 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

L1 Ethereum client L2 Rollup client

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants